Unclosed session detected errors in log | Community
Skip to main content
New Participant
February 9, 2016
Solved

Unclosed session detected errors in log

  • February 9, 2016
  • 11 replies
  • 2060 views

We are seeing this error in the logs. I've seen that the vendor who wrote code for us is using something like this

 ResourceResolver resourceResolver = request.getResourceResolver();
        QueryBuilder queryBuilder = resourceResolver.adaptTo(QueryBuilder.class);
        Session session = resourceResolver.adaptTo(Session.class);

 

Does this session need to be closed in finally as well os it's only when we try to get administrative session that we need to correctly close it?

Any links for best practices while writing servlets and using sessions would be appreciated.

This post is no longer active and is closed to new replies. Need help? Start a new post to ask your question.
Best answer by Feike_Visser1

No, rule is: You create it, you close it. Does not apply for adaptTo()

11 replies

Lokesh_Shivalingaiah
New Participant
February 9, 2016

We need to close the ResourceResolver or the Session which we initiate. Refer [1], [2] in to know more in detail

[1] https://cqdump.wordpress.com/2013/07/23/cq-development-patterns-sling-resourceresolver-and-jcr-sessions/

[2] http://www.wemblog.com/2014/08/how-to-use-sessions-and-resource.html